feat(compiler): compiler supports search and selectedcontent tag
fix #13778
based on #9249, preferably merge that one first and I'll rebase this PR on to it.
related to https://github.com/MananTank/validate-html-nesting/pull/15
closes #13778
see diff compared to #9249: https://github.com/baiwusanyu-c/bwsy-vue-core/compare/bwsy/feat/compilerSearchElm...Calvin-LL:core:calvin/feat/customizable-select
on top of #9249, this adds selectedcontent tag and updated htmlNesting.ts according to the description in HTML specs for the following elements to remove the <b> cannot be child of <a> warnings listed in #13778 and added tests
<select>- HTML specs: https://html.spec.whatwg.org/multipage/form-elements.html#the-select-element
- MDN: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/select
<optgroup>- HTML specs: https://html.spec.whatwg.org/multipage/form-elements.html#the-optgroup-element
- MDN: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/optgroup
<option>- HTML specs: https://html.spec.whatwg.org/multipage/form-elements.html#the-option-element
- MDN: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/option
<selectedcontent>- HTML specs: https://html.spec.whatwg.org/multipage/form-elements.html#the-selectedcontent-element
- MDN: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/selectedcontent
[!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yamlfile in this repository. To trigger a single review, invoke the@coderabbitai reviewcommand.You can disable this status message by setting the
reviews.review_statustofalsein the CodeRabbit configuration file.
✨ Finishing Touches
🧪 Generate unit tests
- [ ] Create PR with unit tests
- [ ] Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. - PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
CodeRabbit Commands (Invoked using PR/Issue comments)
Type @coderabbitai help to get the list of available commands.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Status, Documentation and Community
- Visit our Status Page to check the current availability of CodeRabbit.
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
Size Report
Bundles
| File | Size | Gzip | Brotli |
|---|---|---|---|
| compiler-dom.global.prod.js | 84.7 kB (+615 B) | 30 kB (+223 B) | 26.5 kB (+191 B) |
| runtime-dom.global.prod.js | 104 kB (+65 B) | 39.1 kB (+26 B) | 35.2 kB (+34 B) |
| vue.global.prod.js | 162 kB (+106 B) | 59.3 kB (+30 B) | 52.8 kB (+14 B) |
Usages
| Name | Size | Gzip | Brotli |
|---|---|---|---|
| createApp (CAPI only) | 47.1 kB | 18.4 kB | 16.9 kB |
| createApp | 56 kB | 21.6 kB | 19.7 kB |
| createApp + vaporInteropPlugin | 68.5 kB | 25.8 kB | 23.6 kB |
| createVaporApp | 20.9 kB | 8.26 kB | 7.56 kB |
| createSSRApp | 60.3 kB | 23.3 kB | 21.3 kB |
| defineCustomElement | 61 kB | 23.1 kB | 21.1 kB |
| overall | 70.5 kB | 26.8 kB | 24.4 kB |
@vue/compiler-core
npm i https://pkg.pr.new/@vue/compiler-core@13779
@vue/compiler-dom
npm i https://pkg.pr.new/@vue/compiler-dom@13779
@vue/compiler-sfc
npm i https://pkg.pr.new/@vue/compiler-sfc@13779
@vue/compiler-ssr
npm i https://pkg.pr.new/@vue/compiler-ssr@13779
@vue/compiler-vapor
npm i https://pkg.pr.new/@vue/compiler-vapor@13779
@vue/reactivity
npm i https://pkg.pr.new/@vue/reactivity@13779
@vue/runtime-core
npm i https://pkg.pr.new/@vue/runtime-core@13779
@vue/runtime-dom
npm i https://pkg.pr.new/@vue/runtime-dom@13779
@vue/runtime-vapor
npm i https://pkg.pr.new/@vue/runtime-vapor@13779
@vue/server-renderer
npm i https://pkg.pr.new/@vue/server-renderer@13779
@vue/shared
npm i https://pkg.pr.new/@vue/shared@13779
vue
npm i https://pkg.pr.new/vue@13779
@vue/compat
npm i https://pkg.pr.new/@vue/compat@13779
commit: bfc1eea