core icon indicating copy to clipboard operation
core copied to clipboard

fix(types): retain union type narrowing with defaults applied

Open edison1105 opened this issue 1 year ago • 5 comments

close #12106

edison1105 avatar Oct 04 '24 12:10 edison1105

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB 38.1 kB 34.2 kB
vue.global.prod.js 160 kB 58 kB 51.5 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49.1 kB 18.9 kB 17.3 kB
createApp 55.7 kB 21.4 kB 19.6 kB
createSSRApp 59.7 kB 23.1 kB 21 kB
defineCustomElement 60.4 kB 23 kB 20.9 kB
overall 69.4 kB 26.5 kB 24.1 kB

github-actions[bot] avatar Oct 04 '24 12:10 github-actions[bot]

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12108
@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12108
@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12108
@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12108
@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12108
@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12108
@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12108
@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12108
@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12108
@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12108
vue

pnpm add https://pkg.pr.new/vue@12108

commit: e88722a

pkg-pr-new[bot] avatar Oct 04 '24 12:10 pkg-pr-new[bot]

Could you please check if it somehow helps with https://github.com/vuejs/core/issues/12110 Thanks

darkbasic avatar Oct 04 '24 15:10 darkbasic

Could you please check if it somehow helps with #12110 Thanks

I think it is related to language-tool

edison1105 avatar Oct 05 '24 02:10 edison1105

I'd like to cherry-pick both this and https://github.com/vuejs/core/pull/12059 but I get conflicts with https://github.com/vuejs/core/pull/12059/files#diff-ddb3174016350dd4464764b4a1ba232d09ad1e75164d4a37758c759d019202e4

How would you solve it in the context of the other PR?

darkbasic avatar Oct 08 '24 07:10 darkbasic

/ecosystem-ci run

yyx990803 avatar Oct 11 '24 03:10 yyx990803

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools :x: failure :x: failure
nuxt :white_check_mark: success :white_check_mark: success
pinia :white_check_mark: success :white_check_mark: success
primevue :white_check_mark: success :white_check_mark: success
quasar :white_check_mark: success :white_check_mark: success
radix-vue :white_check_mark: success :white_check_mark: success
router :white_check_mark: success :white_check_mark: success
test-utils :white_check_mark: success :white_check_mark: success
vant :white_check_mark: success :white_check_mark: success
vite-plugin-vue :white_check_mark: success :white_check_mark: success
vitepress :white_check_mark: success :white_check_mark: success
vue-i18n :white_check_mark: success :white_check_mark: success
vue-macros :white_check_mark: success :white_check_mark: success
vuetify :white_check_mark: success :white_check_mark: success
vueuse :white_check_mark: success :white_check_mark: success
vue-simple-compiler :white_check_mark: success :white_check_mark: success

vue-bot avatar Oct 11 '24 03:10 vue-bot

I mistyped the issue number when merging 😓 Amended commit 05685a9d7

yyx990803 avatar Oct 11 '24 03:10 yyx990803

I guess that https://github.com/vuejs/core/pull/12059 needs to be rebased on top of this to fix the remaining issue, right?

darkbasic avatar Oct 11 '24 06:10 darkbasic