core icon indicating copy to clipboard operation
core copied to clipboard

Fix nullabe props not getting undefined union

Open devTeaa opened this issue 1 year ago • 5 comments

close #12098

The original implementation didn't carry over the union type

devTeaa avatar Oct 03 '24 06:10 devTeaa

Can this be merged @edison1105 ?

devTeaa avatar Oct 06 '24 01:10 devTeaa

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12103
@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12103
@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12103
@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12103
@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12103
@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12103
@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12103
@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12103
@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12103
vue

pnpm add https://pkg.pr.new/vue@12103
@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12103

commit: d685cd3

pkg-pr-new[bot] avatar Oct 11 '24 03:10 pkg-pr-new[bot]

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
vue.global.prod.js 159 kB 57.9 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB 18.3 kB 16.7 kB
createApp 55 kB 21.3 kB 19.4 kB
createSSRApp 59 kB 23 kB 20.9 kB
defineCustomElement 59.8 kB 22.8 kB 20.8 kB
overall 68.7 kB 26.3 kB 24 kB

github-actions[bot] avatar Oct 11 '24 03:10 github-actions[bot]

Looks like the type tests are not passing. We also need a test case dedicated for what this intends to fix.

yyx990803 avatar Oct 11 '24 03:10 yyx990803

updated @yyx990803 , @edison1105

devTeaa avatar Oct 11 '24 10:10 devTeaa

Will close then, since it's expected

devTeaa avatar Oct 23 '24 01:10 devTeaa