vue-the-mask icon indicating copy to clipboard operation
vue-the-mask copied to clipboard

Error on empty mask using directive

Open mgesmundo opened this issue 7 years ago • 31 comments

This PR disable the masking when the mask is empty using v-mask directive. All the best

mgesmundo avatar Oct 09 '17 14:10 mgesmundo

nice, I was already seen this error.

thanks

nogueiraever avatar Oct 10 '17 19:10 nogueiraever

+1

zhiga90 avatar Nov 01 '17 13:11 zhiga90

+1

bxavier avatar Nov 30 '17 20:11 bxavier

+1, won't it be merged?

talski avatar Dec 06 '17 19:12 talski

+1

minatonda avatar Dec 14 '17 19:12 minatonda

+1

fabriciobeltran avatar Dec 21 '17 07:12 fabriciobeltran

still waiting ....

DwayneHawkins avatar Jan 10 '18 13:01 DwayneHawkins

@neves

minatonda avatar Feb 21 '18 13:02 minatonda

+1

jsonantunes avatar Mar 28 '18 20:03 jsonantunes

+1

lucassimines avatar May 09 '18 13:05 lucassimines

+1

felippeduarte avatar Jul 27 '18 21:07 felippeduarte

@neves any chance this PR gets merged?

ayrtonvwf avatar Oct 03 '18 23:10 ayrtonvwf

Hasn't been touched for ~6 months... Is it dead?

EDIT: A relatively simple workaround is just using a regular input if no mask is passed.

<template>
  <div>
    <the-mask
      v-if="mask"
      :name="name"
      :value="value"
      :mask="mask"
      @input="handleInput"
    />
    <input
      v-else
      :name="name"
      :value="value"
      @input="handleInput($event.target.value)"
    />
    </div>
</template>

<script>
import Vue from 'vue';
export default Vue.extend({
  methods: {
    handleInput(value) {
      this.$emit('input', value);
    },
  },
  props: {
    mask: {
      type: String,
      default: '',
    },
    name: {
      required: true,
      type: String,
    },
    value: {
      default: '',
    },
  },
});
</script>

JosNun avatar Nov 09 '18 19:11 JosNun

Is this project even active? Seems like no one with access to merge has reviewed this PR.

pleek91 avatar Dec 10 '18 21:12 pleek91

Why isn't this getting merged?

devsoitic08 avatar Dec 12 '18 19:12 devsoitic08

@JosNun yes, we did it this way

DwayneHawkins avatar Dec 12 '18 19:12 DwayneHawkins

+1

vjnrv avatar Dec 13 '18 19:12 vjnrv

+1

diafrit avatar Dec 17 '18 17:12 diafrit

+1 (this PR is over a year forgotten tho)

diguifi avatar Dec 21 '18 17:12 diguifi

+1

ZackStone avatar Jan 03 '19 13:01 ZackStone

+1

pedroramostracker avatar Jan 15 '19 13:01 pedroramostracker

Hasn't been touched for ~6 months... Is it dead?

EDIT: A relatively simple workaround is just using a regular input if no mask is passed.

<template>
  <div>
    <the-mask
      v-if="mask"
      :name="name"
      :value="value"
      :mask="mask"
      @input="handleInput"
    />
    <input
      v-else
      :name="name"
      :value="value"
      @input="handleInput($event.target.value)"
    />
    </div>
</template>

<script>
import Vue from 'vue';
export default Vue.extend({
  methods: {
    handleInput(value) {
      this.$emit('input', value);
    },
  },
  props: {
    mask: {
      type: String,
      default: '',
    },
    name: {
      required: true,
      type: String,
    },
    value: {
      default: '',
    },
  },
});
</script>

i used the same perspective, 2 inputs, one for mask != null other for null

pedroramostracker avatar Jan 15 '19 13:01 pedroramostracker

more than a year has passed

zhiga90 avatar Apr 08 '19 09:04 zhiga90

sad but true

wenderpmachado avatar Apr 10 '19 18:04 wenderpmachado

We have created a fork and published a package with the reference to the author of this project. Also we have merged some major PRs into our fork. If you need more features - feel free to contribute, we are open to PR :)

Package Repo

kaskar2008 avatar Aug 29 '19 11:08 kaskar2008

Very sad to see a good project like this die in this way.

This PR is literally 2 lines of code and fixes a common bug many people are facing.

feliperaul avatar Sep 23 '19 11:09 feliperaul

Same issue here!

galloaleonardo avatar Jan 24 '20 14:01 galloaleonardo

+1

leoclo avatar Jul 17 '20 02:07 leoclo

I had the same error and the outhor of the project has abandoned the nice library, well, I just created a new fork to make that changes but hopeffuly I noticed this PR already did it and @kaskar2008 already created the package, I'm using the ke-the-mask instead. so sad for this project

rodrigorodriguescosta avatar Dec 28 '20 23:12 rodrigorodriguescosta

Still waiting

SinkP avatar Jan 28 '22 01:01 SinkP