ant-design-vue icon indicating copy to clipboard operation
ant-design-vue copied to clipboard

Published 20 hours ago • verified publisher icon vueComponent

improve: shadow dom supports

Open doommm opened this issue 3 years ago • 3 comments
trafficstars

This is a ...

  • [ ] New feature
  • [x] Bug fix
  • [ ] Site / document update
  • [ ] Component style update
  • [ ] TypeScript definition update
  • [x] Refactoring
  • [ ] Code style optimization
  • [ ] Branch merge
  • [ ] Other (about what?)

What's the background?

  • add shadow dom supports to vc-trigger
  • extract getTargetFromEvent function to a separate file

For now, when VcTrigger component is used in ShadowDOM environment(root element is in a shadowRoot), the condition contains(root, target) in onDocumentClick function will get wrong result. This is caused by event retargeting(https://javascript.info/shadow-dom-events)

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • [ ] Doc is updated/provided or not needed
  • [ ] Demo is updated/provided or not needed
  • [ ] TypeScript definition is updated/provided or not needed
  • [ ] Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

doommm avatar Jul 07 '22 10:07 doommm

need more details or discussion? @tangjinzhou

doommm avatar Jul 08 '22 08:07 doommm

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions[bot] avatar Sep 07 '22 04:09 github-actions[bot]

any progress? @tangjinzhou

doommm avatar Sep 07 '22 17:09 doommm

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions[bot] avatar Nov 08 '22 03:11 github-actions[bot]

any progress?

doommm avatar Nov 11 '22 09:11 doommm

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions[bot] avatar Jan 12 '23 02:01 github-actions[bot]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Jan 20 '24 00:01 github-actions[bot]