ant-design-vue icon indicating copy to clipboard operation
ant-design-vue copied to clipboard

The component type definition is wrong in Volar0.27.14

Open Qeney opened this issue 4 years ago • 4 comments

  • [ ] I have searched the issues of this repository and believe that this is not a duplicate.

Version

2.2.6

Environment

Vscode1.60.0,Volar0.27.14

Reproduction link

https://github.com/johnsoncodehk/volar/issues/459

Steps to reproduce

vscode中使用volar插件,详见https://github.com/johnsoncodehk/volar/issues/459

What is expected?

export declare class Button extends AntdComponent { static Group: typeof ButtonGroup; $props: { type?: 'primary' | 'danger' | 'dashed' | 'ghost' | 'default'; htmlType?: 'button' | 'submit' | 'reset' | 'menu'; icon?: string; shape?: 'circle' | 'circle-outline'; size?: 'small' | 'large' | 'default'; loading?: boolean | { delay: number }; disabled?: boolean; ghost?: boolean; block?: boolean; } }

What is actually happening?

export declare class Button extends AntdComponent { static Group: typeof ButtonGroup; type: 'primary' | 'danger' | 'dashed' | 'ghost' | 'default'; htmlType: 'button' | 'submit' | 'reset' | 'menu'; icon: string; shape: 'circle' | 'circle-outline'; size: 'small' | 'large' | 'default'; loading: boolean | { delay: number }; disabled: boolean; ghost: boolean; block: boolean; }

Qeney avatar Sep 06 '21 09:09 Qeney

image

0.27.15 not find some error

tangjinzhou avatar Sep 06 '21 13:09 tangjinzhou

1.x 版本不支持 volar, 你可以尝试pr

tangjinzhou avatar Sep 06 '21 14:09 tangjinzhou

Hello @Qeney. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch, fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @Qeney,我们完全同意你的提议/反馈,欢迎直接在此仓库创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支,务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

github-actions[bot] avatar Sep 10 '21 01:09 github-actions[bot]

image why? today update

qieasan avatar Apr 21 '23 03:04 qieasan