Vue2Leaflet icon indicating copy to clipboard operation
Vue2Leaflet copied to clipboard

Published 20 hours ago • verified publisher icon vue-leaflet

Add LVideoOverlay

Open mandryllo opened this issue 4 years ago • 2 comments

This PR adds LVideoOverlay component (link)

Depends on #685

mandryllo avatar Jul 21 '21 16:07 mandryllo

@mandryllo thanks again for these contributions! I know that there are currently no tests for the LImageOverlay component that you are extending here, but it would be great if you could add some tests both here and in #684 for the new code and components at least. If you had time to backfill the tests for LImageOverlay as well then that would be fantastic, even if it only covered the url prop that's been moved around.

mikeu avatar Jul 27 '21 14:07 mikeu

@mikeu I will add them, probably sometime next week 👍

mandryllo avatar Jul 30 '21 13:07 mandryllo