vue-dark-mode icon indicating copy to clipboard operation
vue-dark-mode copied to clipboard

Vue 3 support

Open martinschaer opened this issue 3 years ago • 3 comments

Hi!

I forked this to make it compatible with Vue 3 + TS on my current project. I need to clean it up a bit to send a PR, but first I wanted to know if there are any thoughts about this.

Thanks!

martinschaer avatar Nov 26 '21 16:11 martinschaer

One thought to start: I would avoid overloading prop types like favicon (string or boolean) and storage (string or object). I actually had to avoid this to make it work with TypeScript.

More about this in point 5 –Don't Overload Your Prop Types– on this article: https://michaelnthiessen.com/unlock-full-potential-prop-types/

martinschaer avatar Nov 26 '21 16:11 martinschaer

@martinschaer

Awesome! We will be grateful to receive your support in this.

ktquez avatar Nov 26 '21 20:11 ktquez

I wanted to use this package and it took me so long to figure out its not Vue 3 capable. Back to the search for a Vue 3 dark mode.

ItsRainingHP avatar Jun 30 '23 17:06 ItsRainingHP