ose icon indicating copy to clipboard operation
ose copied to clipboard

Inventory Drag and Drop Streamline

Open xanstin opened this issue 3 years ago • 6 comments

New Feature or Changed Behaviour

Inventory itself is a bit cumbersome as you cant drag and drop from items directory into a container it has to go to misc first then dragged into a bag.

There is also not a true way to move things you can only create copies when dragging and dropping from another PC.

Why?

This just adds time to moving things around.

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

xanstin avatar Nov 14 '22 04:11 xanstin

I am unable to reproduce this behavior with the latest OSE version. Is it still relevant?

bakbakbakbakbak avatar Jan 16 '23 07:01 bakbakbakbakbak

If you drag a new item into the inventory and try to drag straight into a bag it still puts it in misc instead of the container.

If I drag an item from one PC to another it still just creates a copy instead of moving it.

On 1.7.3

xanstin avatar Jan 16 '23 15:01 xanstin

aah, I recreated it now. It is only when I drag items from Items & Compenium and not within the actor itself it happens. I'll see if I find the problem!

bakbakbakbakbak avatar Jan 16 '23 16:01 bakbakbakbakbak

@xanstin : I'm writing these tests, do they correspond to the expected behavior?

it('Move item from Items to actor's container inventory', async () => { // Create new non-Actor item // Drag and Drop item to container // Expect container to contain item }) it('Move item from Items Compendium to actor's container inventory', async () => { // Create compendium // Create new non-Actor item // Drag and Drop item to container // Expect container to contain item })

bakbakbakbakbak avatar Jan 16 '23 16:01 bakbakbakbakbak

@bakbakbakbakbak I'd expect the item to not exist in actor.system.items, as well: https://github.com/vttred/ose/blob/6cf617d755328edde8948968b6048409bbf8cffd/src/module/actor/data-model-character.js#L145-L151

wyrmisis avatar Jan 16 '23 17:01 wyrmisis

I'm working on fixes to containers to also fix #310, so I'll look at this at the same time.

bakbakbakbakbak avatar Jan 21 '23 13:01 bakbakbakbakbak