vtorri

font renderer

6

https://typedesign.netlify.app/tdrenderer.html

[discussion] about perf code

4

in perf.h, 2 declarations seem unnecessary to me : lexbor_perf_frequency() and lexbor_perf_clock() perf code is used to compute time in second of a part of code. So i would say...

If unit tests are written, i would suggest to use a tool which can be integrated in github, like https://coveralls.io/

[discussion] about memory allocation wrappers

1

some questions : 1) Why did you add wrappers around memory management ? 2) why is the wrapper around free() returning a void * ? That seems strange 3) do...

Openindiana (solaris): error in gzip.c

2

with git of today, 2 errors and 1 warning in gzip.c line 357, the 2 errors with incompatible types when initializing line 359 : futimens is not declared illumos made...

I've tested the unit tests (on Windows) and I have remarked that png (or jpeg, or etc..) tests are failing when png loader is not enabled. Which seems normal. But...

unifying svg2png and svg2tvg

2

what about unifying the 2 tools into a program ? for example tvg-convert ? A bit like librsvg convert tool. The reasons behind this proposal are * unifying the code...

about TVG_EXPORT and Windows

4

Hello about TVG_EXPORT: * it should be available on Windows for both Microsoft compiler and mingw, so line 21 of thorvg.h : ` #if defined(_WIN32) && !defined(__clang__)` * I've not...

is there a need for a Direct3d engine ?

5

There is an OpenGL engine, but OpenGL support on Windows is not great. Is there a need for a Direct3D11 engine for ThorVG ?

cmake: CMakeLists.txt sets Windows macroup to win8, not win 10

2

line 245 and after of CMakeLists.txt, no mention of Windows 10. But win7 and win8 are (or will be soon) unsupported so maybe it would be nice to: 1) add...