Jameson Nash

Results 938 comments of Jameson Nash

This seems a common misconception, so just note that that comment does not reflect what atomic rename is documented to mean on Unix or anywhere else either. The atomic only...

No, most file systems usually won't permit a hard link to be created to a directory

Yeah, it feels like someone really needs to rewrite a lot of that code in Filesystem better. It is currently intended to replicate the [`mv`](https://man.freebsd.org/cgi/man.cgi?query=mv(1)) command with `force` instead of...

> First analyzegc failure looks incorrect, it seems to incorrectly think `uv_dup` could return 0 when `dupfd` is set to `-1` (minimal reproducer https://godbolt.org/z/4Wo99v1nv, [llvm/llvm-project#43015](https://github.com/llvm/llvm-project/issues/43015) looks to be the same...

IIUC, someone deleted support for printing comments on our end: ``` std::unique_ptr S(TM->getTarget().createAsmStreamer( #if JL_LLVM_VERSION >= 190000 *Context, std::move(FOut), InstPrinter, std::move(MCE), std::move(MAB) #else *Context, std::move(FOut), /*AsmVerbose*/true, true, InstPrinter, std::move(MCE), std::move(MAB),...

> /usr/lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/optional:236:18: note: Calling implicit destructor for 'ConstantRange' > 236 | ~_Storage() { } That is odd. The C++ standard says that this implicit destructor is not permitted to be...

MWE for the apparent clang-analyzer mistake: ```console vtjnash@deepsea4:~/julia$ clang++ -fPIE -std=c++20 dtor-test.cpp && ./a.out C Ctor C Dtor vtjnash@deepsea4:~/julia$ g++ -fPIE -std=c++20 dtor-test.cpp && ./a.out C Ctor C Dtor $...

patch to add to fix this https://github.com/JuliaLang/julia/pull/56130#issuecomment-2512298690 ```diff diff --git a/src/disasm.cpp b/src/disasm.cpp index b944e48430c..cc296618635 100644 --- a/src/disasm.cpp +++ b/src/disasm.cpp @@ -873,6 +873,8 @@ static void jl_dump_asm_internal( SourceMgr SrcMgr; MCTargetOptions Options;...

It may cause a memory leak, since it fails to get destroyed

The second does, but not the first