Vasilis Themelis

Results 69 comments of Vasilis Themelis

Hi @connernilsen, would it be possible to get a review on this? It's pretty awkward to use the pyre vscode extension without this change.

Thank you very much @connernilsen !

Hi guys, can I still get a review for this?

Thanks for the review @connernilsen! There is an event listener that restarts pyre when the user switches environments here https://github.com/facebook/pyre-check/pull/820/files#diff-1141a7840adc35ecfd0234d6fe8484e7aec33f72306fd32bada0037336ea1f3eR47-R56 Did that not work for you? I'm happy to also...

Hello @kinto0, thanks for importing the PR! Is there anything I can do to help merge it?

> For test failures on Python < 3.10 see: > > * [Run GitHub Actions tests on current versions of Python #832](https://github.com/facebook/pyre-check/pull/832) Thanks, I can merge `main` into this branch...

> would you mind taking a look at my error? I see it when testing with or without the python extension enabled Thanks a lot for the review @kinto0 !...

@kinto0, does this work for you now?

> did you make a change? I don't see it on my side Yes, it's the last commit in the PR. It's also referenced by hash in my reply to...