faststore icon indicating copy to clipboard operation
faststore copied to clipboard

Banner component

Open gvc opened this issue 3 years ago • 3 comments

I'm creating this issue to let chime in if this should be an atom/molecule or organism and if it should be implemented on faststore or on base.store.

The Banner component is a content driven component that displays some text and an image.

Figma link

gvc avatar Dec 01 '21 14:12 gvc

This can be done on @faststore/ui, however, I see no benefits on doing it in there because the implementation would be an empty div that renders children. However, if you think in better ways of implementing this, I'd say this is an organism

tlgimenes avatar Dec 02 '21 14:12 tlgimenes

Yes, this should be done on faststore as an organism

emersonlaurentino avatar Dec 02 '21 18:12 emersonlaurentino

After few discussion we decided to classify it as molecule https://github.com/vtex/faststore/pull/1048, but I still think it suits better as an organism.

hellofanny avatar Aug 02 '22 02:08 hellofanny

closing because https://github.com/vtex/faststore/pull/1048 was merged

emersonlaurentino avatar Jan 13 '23 14:01 emersonlaurentino