store-components icon indicating copy to clipboard operation
store-components copied to clipboard

feat/sku-variation-color-props

Open moran-dev opened this issue 4 years ago • 2 comments

What problem is this solving?

The context of the change was basically because SKU Color Variation always display a button with a image inside and don't have a props to change that behavior. In this project, we had this particular design for Color variation. So, I made it possible to control this particular variation with a boolean value.

How to test it?

1- Open the Workspace. 2- Use ReactDevTools to change props between true or false. (https://prnt.sc/1t4qy5u)

Workspace

Screenshots or example usage:

Before ( Normal SKU-Selector as Store-Theme)

After:

isImage: true

  • https://prnt.sc/1t4knn5
  • https://prnt.sc/1t4kpdq

isImage: false

  • https://prnt.sc/1t4ktoq
  • https://prnt.sc/1t4kslf

How does this PR make you feel? :link:

Smile

moran-dev avatar Sep 21 '21 18:09 moran-dev

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • [ ] Patch (backwards-compatible bug fixes)

  • [ ] Minor (backwards-compatible functionality)

  • [ ] Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • [ ] No thanks, I would rather do it manually 😞

vtex-io-ci-cd[bot] avatar Sep 21 '21 18:09 vtex-io-ci-cd[bot]

Beep boop :robot:

Thank you so much for keeping our documentation up-to-date :heart:

vtex-io-docs-bot[bot] avatar Sep 21 '21 18:09 vtex-io-docs-bot[bot]