store-components icon indicating copy to clipboard operation
store-components copied to clipboard

Feature/pdp fetch priority

Open gabridevs opened this issue 1 year ago • 2 comments

What problem is this solving?

This change improves page performance by ensuring the main product image is prioritized during loading. By setting the fetchpriority: 'high' for the first product image, we ensure that the most important image (usually the first one) is loaded first, enhancing user experience, especially for pages with multiple images.

How to test it?

You can test this change by visiting the following workspace where the branch is linked. Check the loading behavior of the first product image, ensuring it is loaded before others when opening a product page.

[Workspace](Link goes here!)

Screenshots or example usage:

Screenshot 2024-10-16 alle 19 57 52

Describe alternatives you've considered, if any.

No alternatives considered as fetchpriority: 'high' is a straightforward and effective solution for this problem.

gabridevs avatar Oct 17 '24 09:10 gabridevs

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • [ ] Patch (backwards-compatible bug fixes)

  • [ ] Minor (backwards-compatible functionality)

  • [ ] Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • [ ] No thanks, I would rather do it manually 😞

vtex-io-ci-cd[bot] avatar Oct 17 '24 09:10 vtex-io-ci-cd[bot]

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

* [ ]  Patch (backwards-compatible bug fixes)

* [x]  Minor (backwards-compatible functionality)

* [ ]  Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

* [ ]  No thanks, I would rather do it manually 😞

gabridevs avatar Oct 17 '24 09:10 gabridevs

I would also request that you:

  • fix conflicts in CHANGELOG.md
  • provide an up to date and working workspace

vmourac-vtex avatar Jun 06 '25 13:06 vmourac-vtex

I would also request that you:

* fix conflicts in `CHANGELOG.md`

* provide an up to date and working workspace

Hi @vmourac-vtex i have update workspace and CHANGELOG.md

gabridevs avatar Jun 25 '25 13:06 gabridevs

@gabridevs it seems you missed some some of the requests in earlier messages. We could also improve on the way you handled the CHANGELOG.md fix. I'll summarize what still needs to be done here:

  • This PR should only contain the changes related to this task. Currently it is mixed with #1120. Please recreate/interactively rebase, etc, in order to only include commits and changes related to the task proposed in the PR
  • Fix conflicts on CHANGELOG.md - You fixed the conflicts by removing your changes in this file. The root issue was that your branch diverged from this repo master branch. Reconcile the branches and then add to CHANGELOG.md what you added/removed/changed in this PR

vmourac-vtex avatar Jun 27 '25 15:06 vmourac-vtex