store-components icon indicating copy to clipboard operation
store-components copied to clipboard

Configurable thumbnail dimensions in product gallery

Open gabridevs opened this issue 1 year ago • 3 comments

What problem is this solving?

This PR adds the ability to configure the width and height of product thumbnails in the carousel component. By allowing control over the thumbnail dimensions, this can improve page performance and SEO by ensuring that appropriately sized images are used, reducing unnecessary data loading.

How to test it?

You can test this feature by setting custom values for thumbCustomWidth and thumbCustomHeight in the product image gallery component. Ensure that thumbnails are resized correctly based on these values, and monitor the impact on page load times and SEO scores.

For test use this Workspace

Screenshots or example usage:

In production: Official component in production unable to set thumbnail size. See props: Product Image

In workspace:

Screenshot 2024-09-17 alle 16 25 54

can be able to set values in px from props component: Screenshot 2024-09-17 alle 16 43 40

Describe alternatives you've considered, if any.

An alternative approach considered was to use CSS only for thumbnail resizing, but this would not allow for dynamic configuration through props or tailored image dimensions for performance.

Related to / Depends on

No dependencies.

gabridevs avatar Sep 17 '24 14:09 gabridevs

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • [ ] Patch (backwards-compatible bug fixes)

  • [ ] Minor (backwards-compatible functionality)

  • [ ] Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • [ ] No thanks, I would rather do it manually 😞

vtex-io-ci-cd[bot] avatar Sep 17 '24 14:09 vtex-io-ci-cd[bot]

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

  • [ ] There's nothing new to document :thinking:
  • [ ] I'll do it later :disappointed:

In order to keep track, I'll create an issue if you decide now is not a good time

  • [ ] I just updated :tada::tada:

vtex-io-docs-bot[bot] avatar Sep 17 '24 14:09 vtex-io-docs-bot[bot]

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

* [ ]  There's nothing new to document 🤔

* [ ]  I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

* [x]  I just updated 🎉🎉

gabridevs avatar Sep 17 '24 14:09 gabridevs

@gabridevs the workspace provided in the PR is not working. Please update the PR description with a proper workspace and detailed step by step procedures do reproduce the behavior

vmourac-vtex avatar Jun 06 '25 13:06 vmourac-vtex

@gabridevs the workspace provided in the PR is not working. Please update the PR description with a proper workspace and detailed step by step procedures do reproduce the behavior

Hi @vmourac-vtex, the worksoace is now working again. Check please

gabridevs avatar Jun 24 '25 18:06 gabridevs

hi @vmourac-vtex , i opened a new PR for this scenario and i create a separate branch for pr: https://github.com/vtex-apps/store-components/pull/1140

gabridevs avatar Jul 16 '25 14:07 gabridevs