render-runtime icon indicating copy to clipboard operation
render-runtime copied to clipboard

change desktop determination to be not mobile

Open sperks-syatt opened this issue 3 years ago • 2 comments

What does this PR do? *

Fixes this issue: https://github.com/vtex-apps/render-runtime/issues/635

This is a temporary fix for render-runtime displaying mobile at 1025px. A more permanent solution should be sought to ensure that render-runtime works better with tachyons (tachyons display all media queries with a mobile first approach, thus rendering min-width: 64rem as desktop too.

How to test it? *

resize your browser to 1025px and note that this fix allows that to display as desktop.

Describe alternatives you've considered, if any. *

Alternatives would be to set all css media queries within our app as 64.1rem for desktop.

Related to / Depends on *

sperks-syatt avatar Apr 17 '22 15:04 sperks-syatt

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • [ ] Patch (backwards-compatible bug fixes)

  • [ ] Minor (backwards-compatible functionality)

  • [ ] Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • [ ] No thanks, I would rather do it manually 😞

vtex-io-ci-cd[bot] avatar Apr 17 '22 15:04 vtex-io-ci-cd[bot]

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

  • [ ] There's nothing new to document :thinking:
  • [ ] I'll do it later :disappointed:

In order to keep track, I'll create an issue if you decide now is not a good time

  • [ ] I just updated :tada::tada:

vtex-io-docs-bot[bot] avatar Apr 17 '22 15:04 vtex-io-docs-bot[bot]