render-runtime icon indicating copy to clipboard operation
render-runtime copied to clipboard

Fix external page navigation

Open brunoabreu opened this issue 5 years ago • 2 comments

What does this PR do? *

It fixes a problem when navigating to a page not served by render with the navigate function.

It also removes a lot of old code.

How to test it? *

Reproducing the current error

  1. Go to https://storetheme.vtex.com/
  2. Open chrome devtools
  3. Go to the Components tab, from React Developer Tools
  4. Click on the n component in the tree (it is the RenderProvider)
  5. Run $r.navigate({to: '/checkout'}) in the console and you will se the error

image

Now reproduce the steps in https://navigation--storecomponents.myvtex.com where this branch is linked. It works fine

Describe alternatives you've considered, if any. *

Related to / Depends on *

brunoabreu avatar Oct 20 '20 22:10 brunoabreu

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

  • [x] There's nothing new to document :thinking:
  • [ ] I'll do it later :disappointed:

In order to keep track, I'll create an issue if you decide now is not a good time

  • [ ] I just updated :tada::tada:

vtex-io-docs-bot[bot] avatar Oct 20 '20 22:10 vtex-io-docs-bot[bot]

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • [x] Patch (backwards-compatible bug fixes)

  • [ ] Minor (backwards-compatible functionality)

  • [ ] Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • [ ] No thanks, I would rather do it manually 😞

vtex-io-ci-cd[bot] avatar Oct 20 '20 22:10 vtex-io-ci-cd[bot]