render-runtime icon indicating copy to clipboard operation
render-runtime copied to clipboard

add bindingaddress qs on pickruntime request

Open jgfidelis opened this issue 4 years ago • 2 comments

What does this PR do? *

On myvtex, there is no rootpath, a lot of the requests base themselves on __bindingAddress querystring.

The pickruntime for prefetch was not being done with this qs and so what resulting in errors.

This pr fixes it and does not break what should keep working

How to test it? *

Navigate here: https://fidelis--powerplanet.myvtex.com/?__bindingAddress=b2c.powerplanet.com/pt

And here: https://storetheme.vtex.com/?workspace=fidelis

Describe alternatives you've considered, if any. *

Related to / Depends on *

jgfidelis avatar Jul 29 '20 19:07 jgfidelis

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • [x] Patch (backwards-compatible bug fixes)

  • [ ] Minor (backwards-compatible functionality)

  • [ ] Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • [ ] No thanks, I would rather do it manually 😞

vtex-io-ci-cd[bot] avatar Jul 29 '20 19:07 vtex-io-ci-cd[bot]

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

  • [x] There's nothing new to document :thinking:
  • [ ] I'll do it later :disappointed:

In order to keep track, I'll create an issue if you decide now is not a good time

  • [ ] I just updated :tada::tada:

vtex-io-docs-bot[bot] avatar Jul 29 '20 19:07 vtex-io-docs-bot[bot]