product-customizer icon indicating copy to clipboard operation
product-customizer copied to clipboard

Stop click propagation when input has values to avoid unchecking accidentally

Open wender opened this issue 2 years ago • 4 comments

What problem is this solving?

When a user enters customization and clicks it back to check or make any changes, it unchecks the attachment selection.

How to test it?

Problem

Working Fix

wender avatar Oct 25 '22 19:10 wender

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

  • [x] There's nothing new to document :thinking:
  • [ ] I'll do it later :disappointed:

In order to keep track, I'll create an issue if you decide now is not a good time

  • [ ] I just updated :tada::tada:

vtex-io-docs-bot[bot] avatar Oct 25 '22 19:10 vtex-io-docs-bot[bot]

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • [x] Patch (backwards-compatible bug fixes)

  • [ ] Minor (backwards-compatible functionality)

  • [ ] Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • [ ] No thanks, I would rather do it manually 😞

vtex-io-ci-cd[bot] avatar Oct 25 '22 19:10 vtex-io-ci-cd[bot]

I still get some weird behaviors sometimes. If I click "Add Text", add nothing to the lines, click again and then add something to the lines, the checkbox is still unchecked.

If I click "Add Text", fill any line with any text, Click "Add Text" again, remove everything, then click "Add Text" again and enter any content, the checkbox is unchecked.

I don't think the logic is correct just yet. I think a more consistent way of doing this would be: If the checkbox is checked, never uncheck it by clicking the "Add Text" button.

Also, I didn't understand your reply saying "The first is always the name". Which name? In this store only or in any store?

icazevedo avatar Nov 01 '22 15:11 icazevedo

Hello @wender, is this still needed?

danzanzini avatar Jan 02 '23 19:01 danzanzini