admin-pages icon indicating copy to clipboard operation
admin-pages copied to clipboard

Hide query strings from the site editor top bar

Open vitorflg opened this issue 4 years ago • 2 comments

Validate this PR instead ->> https://github.com/vtex-apps/admin-pages/pull/374

What problem is this solving?

The query strings of the site editor URL input get in the way of the iframe pathname, which is not good for the user experience. Hiding it from the top bar but keeping that in the window.location.search works better!

How should this be manually tested?

Workspace

Two main points to be tested with this change:

  • Binding keeps working.
  • Block selector keeps working.

Screenshots or example usage

Before: Screen Shot 2021-01-29 at 6 05 09 PM

After: Screen Shot 2021-01-29 at 6 05 27 PM

Type of changes

✔️ Type of Change
_ Bug fix
_ New feature
_ Breaking change
✔️ Technical improvements

Notes

X

vitorflg avatar Jan 29 '21 21:01 vitorflg

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • [ ] Patch (backwards-compatible bug fixes)

  • [x] Minor (backwards-compatible functionality)

  • [ ] Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • [ ] No thanks, I would rather do it manually 😞

vtex-io-ci-cd[bot] avatar Jan 29 '21 21:01 vtex-io-ci-cd[bot]

Beep boop :robot:

I noticed you didn't make any changes at the docs/ folder

  • [x] There's nothing new to document :thinking:
  • [ ] I'll do it later :disappointed:

In order to keep track, I'll create an issue if you decide now is not a good time

  • [ ] I just updated :tada::tada:

vtex-io-docs-bot[bot] avatar Jan 29 '21 21:01 vtex-io-docs-bot[bot]