Victor Stinner

icon indicating a website link http://vstinner.readthedocs.io/ icon indicating an email [email protected]

icon company @RedHatOfficial icon location France icon location Maintain Python upstream (python.org) and downstream (RHEL and Fedora) for Red Hat. @python core developer.

Results 702 comments of Victor Stinner

gh-121645: Add PyBytes_Join() function

@serhiy-storchaka: I addressed most of your comments, except of the one one the doc: > ``NULL`` which is treated as an empty string.

gh-121645: Add PyBytes_Join() function

@encukou: I updated the PR to address your review.

gh-121645: Add PyBytes_Join() function

> @vstinner This might need a merge / rebase after https://github.com/python/cpython/pull/122267. Done.

gh-121645: Add PyBytes_Join() function

I created https://github.com/capi-workgroup/decisions/issues/36

gh-121645: Add PyBytes_Join() function

> I created https://github.com/capi-workgroup/decisions/issues/36 It was decided to reject NULL separator. I updated my PR to respect the C API Working Group decision. I also rebased the PR to fix...

gh-121645: Add PyBytes_Join() function

> Please do not use rebase so later in the review. Do you mean that rebasing on main is bad, or is squashing commits which is bad for review? Sorry,...

gh-121645: Add PyBytes_Join() function

Merged, thanks for reviews.

Remove commit bit from inactive core devs

It would be useful to know the effective number of active core devs to take better decisions. It's not the same if we have 30 or 150 "active" core devs....

Remove commit bit from inactive core devs

I like your plan. > (3) For those that don't reply After how long?

2.6.2: sphinx warnings `reference target not found`

@amritamishra01: Go ahead if you want to propose a fix.