Victor Stinner

Results 709 comments of Victor Stinner

I still don't understand how moving global variables into _PyRuntime does solve any problem. What are the advantages of moving a variable declared as "static" in a C file into...

@pablogsal asked to add ``__has_feature(c_static_assert)`` check. I don't see this check in your PR yet. Does it mean that you are against using it, and if yes, why?

@ronaldoussoren: > Why can syslog.syslog only be used when the main interpreter has called syslog.openlog? That's a restriction that is not present in the underlying library. The limitation comes from...

One problem with sub-interpreters is that Python objects should not travel from one interpreter to another. But ``static PyObject *S_ident_o`` can become a memory copy of the UTF-8 encoded string...

> I think we should explore the option of a merge strategy that doesn't require manual backports, but if we can't find one, or if someone with git expertise can...

What I mean is that people had 2 years to look into the Git issue and so far nobody was able to provide a solution to the Git issue. So...

Merged, thanks for the review!

> OTOH we would probably also like an opinion to disable this entirely and do it ourselves. That can be a separated option. IMO this change alone is already an...

> Not sure, but the CI test failure on Windows seems to be unrelated. ``Result: FAILURE then SUCCESS`` is an unstable test: test_asyncio.test_windows_events failed and then passed when re-run, you...