Victor Stinner

You should be able to use "python3 -m perf compare_to ref.json patch.json" command to compare your two benchmark results. In perf, a warning is emitted if perf cannot check if...

I don't recall file formats which store a timezone. Which file format are you thinking about?

I used `git commit --amend --no-edit --signoff` to sign off my commit.

It seems like multiple issues come from this function: ``` PyTracebackObject *tb_create( PyTracebackObject *last_traceback, PyObject *dict, const char* filename, const char* funcname, int linenum) ``` I suggest you using the...

cc @encukou

> Check how Cython does that * Cython __Pyx_AddTraceback() function: https://github.com/cython/cython/blob/3424926e9c8f03061b55516d2516a9f98999399e/Cython/Utility/Exceptions.c#L793-L907 * Cython __Pyx_PyCode_New() function: https://github.com/cython/cython/blob/3424926e9c8f03061b55516d2516a9f98999399e/Cython/Utility/ModuleSetupCode.c#L601-L669 Cython __Pyx_AddTraceback() has a short implementation using the private _PyTraceback_Add() function, and a long...

> Thrameos closed this as completed in #1087 8 days ago Great! Congrats :-)

native/python/pyjp_value.cpp: ``` // Horrible kludge because python lacks an API for allocating a GC type with extra memory // The private method _PyObject_GC_Alloc is no longer visible, so we are...

I suggest you waiting until https://github.com/python/cpython/pull/96047 is merged, and then test pybind11 again on a Python containing this change.

Ok, enough nitpicking. This version is good enough to be merged. We can always enhance tests and doc later if needed. Thanks a lot @noamcohen97 for updating your PR many...