libucl icon indicating copy to clipboard operation
libucl copied to clipboard

Removed an assertion in msgpack

Open AdamKorcz opened this issue 4 years ago • 2 comments

I ran the tests, and the results were the same before and after this update

AdamKorcz avatar Apr 22 '20 13:04 AdamKorcz

I'm not quite sure that this particular assertion should be removed. Assertions are used to prevent library misusage. A missing parser object is definitely an example of misusage.

Assertions on bad inputs should definitely be removed, on the contrary.

vstakhov avatar May 04 '20 12:05 vstakhov

I agree. We can't, however, fuzz the msgpack functionality, if misusage causes our fuzzers to stop completely in an abort. The rewrite from an abort to the ucl_create_err() will allow our fuzzers to run continuously. I should note that we most likely need this to be done on all aborts in the msgpack-functionality, so if a few ones are essential then it won't be necessary to rewrite the rest.

AdamKorcz avatar May 06 '20 10:05 AdamKorcz