Vitalie Spinu

Results 368 comments of Vitalie Spinu

This is hard given current parser's flexibility. One need to choose restrictions, either enforce separators or enforce 2 or 4 digits years. Maybe something could be done in the internal...

I can add a 3 year matcher for the case when separator are present. But the low level parse would still need to understand it, which it current doesn't I...

This is not what is normally called minimal reproducible example. If I understand correctly you are not happy with the fact that lubridte rounding with days starts with the beginning...

Your understanding is correct. What you call "clustering by month" is what I call "origin of rounding is 1st of month". I see the use case when one would want...

So you basically want to have the ability to round to an evenly ditributed time grid. If we add an option to specify the rounding origin then it would solve...

More generally, a user can supply the grid and then rounding to the closest. In other words alignment, or rolling in data.table parlance.

Very good idea. Would be happy to accept a PR in this regard.

Regarding the format. I think english names should be there regardless of the locale and for the current locale the internal `.get_locale_regs` should be helpfull: ```R > lubridate:::.get_locale_regs()$wday_names $abr [1]...

> To ensure consistent with latest tidyverse styling guidelines; I hope they are not too opinionated and Rstudio centric. Otherwise, I am completely fine with this idea.

2:AM is borderline. It probably makes sense to parse it actually. I would say this is a bug.