Vitalie Spinu

Results 368 comments of Vitalie Spinu

> Btw, when will connections be removed from this map? Each connection should manage it's own entry and delete it on exit. Of course there will be orphaned entries for...

> Add extra arguments weight_init=..., bias_init=... to eqx.nn.{Linear, Conv, MultiheadAttention, ...}. May I suggest having instead one `init` dict argument. Then passing initializers to nested sublayers could follow the same...

This is a consequence of the fact that formats are trained on a subset of the vector for efficiency reasons. A well known an documented issue I think the training...

It matters only when people use antlr on python side and want to match spark's version. Spark's dependency is on java side, hence no conflicts so far :) I understand...

It's actually not. Sorry for late reply, our internal pip mirror takes at least two weeks to update the packages and I switched to a different project in meanwhile. Now...

I am really confused, while `fugue-sql-antlr` is no [longer](https://github.com/fugue-project/fugue-sql-antlr/blob/master/setup.py#L105-L109) requiring `antlr4-python3-runtime` 4.11 that is not propagated to the pip package: ``` fugue-sql-antlr==0.1.7 - antlr4-python3-runtime [required: >=4.11.1,=2.0, installed: 2.1.2] - triad...

Arh, ... it's still in the [requirements.txt](https://github.com/fugue-project/fugue-sql-antlr/blob/master/requirements.txt#L1)

Would be great to have a rectangular box and simple lines. Both of these are defined by two points. All other extras don't seem that much useful.

Just to confirm, you want a Date object with time zone? Normally Date objects don't have a time zone. But given that we accept a `tzone` argument we should attach...

I wold happily approve a PR for this. I think it's a nice addition to the package. But docs, tests and news entry should be added. Also please use `ISOdate`...