Vitalie Spinu comments

Results 368 comments of


                                            Vitalie Spinu

xref-find-references fails with "Wrong type argument: hash-table-p, nil"

Wait a sec, which map do you mean? `lsp-mode-map` is empty. I have just spent an entire evening populating my own `java-mode-map` with lsp commands trying to figure out what...

xref-find-references fails with "Wrong type argument: hash-table-p, nil"

Well, of course. My suggestion was to provide an example of a java-mode-map configuration with all the functionality currently available, even better a separate configuration or a function which would...

--recursive in clone?

Is this one hard? I guess libgit2 supports this out of the box.

Give preference to exact matches

> Matchscore never ignored, So $y$ is a match score in [0, 1] an $x$ is the `usage score`. Not bad. Then within the same partial match group candidates are...

0-hour an error in ymd_h but not in ymd_hm

Thanks for reporting this. Finally got down to fixing this.

daylight saving breaks `+minutes()`

I think a real valid issue here is that addition and subtraction do not behave symmetrically with respect to DST transition. I opened #1088 for this. Reversibility can never by...

update and make_datetime handling of Februray 29

`roll` argument wasn't affecting rolling behavior of month days. It was controling only the DST skipped behavior. There are new arguments in lubridate `roll_month` and `roll_dst` which allow for full...

Mathematical operations with infinite dates and datetimes

Has been fixed.

leap second for 1969?

It's working correctly in devel

`round_date()` always rounds Date objects down when rounding unit is "week" (but correctly rounds POSIXct)

Indeed, it is fixed in devel, but CRAN release is badly overdue. Sorry about that :weary: . Will release this week.