docsy-jekyll icon indicating copy to clipboard operation
docsy-jekyll copied to clipboard

Issue: Changing assets in assets/favicons/ doesn't change icon on homepage

Open neotamias opened this issue 4 years ago • 5 comments

image Icons are changed inside assets/favicons/

image website doesn't change

image built fine and it is loading as the favicon the browser is loading has changed

neotamias avatar Feb 17 '21 01:02 neotamias

The icon on the home page is not derived from the favicon, it's the logo.svg file in includes, linked here https://github.com/vsoch/docsy-jekyll/blob/master/_includes/header.html#L4.

vsoch avatar Feb 17 '21 01:02 vsoch

thank you! can you add that to the instructions?

neotamias avatar Feb 17 '21 01:02 neotamias

Would you care to contribute a PR to add it?

vsoch avatar Feb 17 '21 01:02 vsoch

i can do that for sure

neotamias avatar Feb 17 '21 01:02 neotamias

@neotamias did you plan to contribute here or should we close this?

vsoch avatar Mar 30 '21 21:03 vsoch