Václav Slavík

Results 318 comments of Václav Slavík

I’m pretty sure I used `target="_blank"` with Sparkle in the past, but I may be mistaken. This of course changes the situation, reopening.

So, this is one of those things that are much more complicated than they sound: https://stackoverflow.com/questions/2925279/iwebbrowser2-how-to-force-links-to-open-in-new-window Using `DISPID_BEFORENAVIGATE2` *may* be OK in the limited situation of release notes. There's a...

Note also that it appears that `target="_blank"` launches MSIE, not user's default browser, when using the WebBrowser control - see https://github.com/vslavik/winsparkle/issues/227#issuecomment-1280037864.

Please submit a PR with the fix, then. As one of the *very* few users of this callback, you’re in the best position to do it and contribute back.

It's possible this too is due to your application's configuration — did you try to reproduce in the bundled example? It's also possible updating the bundled wx library would fix...

> This is not a WinSparkle issue, per se. Honestly, I think it is, as mentioned above - updating wxWidgets to a current version is likely to either fix it...

cb5ac6e71fbc80bcca502cc2fb9e9ec1ba1f11ee is the responsible commit. I think this simple change *should* fix it: ```diff --- a/cmake/expat/CMakeLists.txt +++ b/cmake/expat/CMakeLists.txt @@ -1,6 +1,6 @@ project(expat) -set(SOURCE_DIR ${ROOT_DIR}/3rdparty/expat) +set(SOURCE_DIR ${ROOT_DIR}/3rdparty/expat/expat) cmake_minimum_required(VERSION 2.6) set(PACKAGE_BUGREPORT...

> I've tried - it is much more complicated. Sorry :(

> I have own fix. @drizt Please submit a PR. Thanks!

> What is the best way to do it? None. > Is there a chance that the required changes are integrated here? Frankly, no. It is an explicit design goal...