signalilo
signalilo copied to clipboard
No spaces in validateServiceName allowed
Hello,
I was searching for a while, after I realized, that signalilo cannot handle alertnames with spaces correctly. You can repreduce my problem if you fire an alert with an Alertname like "This is a test".
The regex https://github.com/vshn/signalilo/blob/master/webhook/icinga.go#L28 prevents that anything with a space will be sent to icinga2. Is there a reason, that there is no string replace to convert spaces to underscores or just properly encode the spaces to the GET method for the Icinga2 API?
I would love to see this fixed, since many people are using spaces in their names.
Thanks and best regards, Dennis