VulkanSceneGraph
VulkanSceneGraph copied to clipboard
[ADDED] Dynamic descriptors
Description
Added dynamic descriptor buffer support for buffering of per frame data as used for example in vsg::ViewDependentState
Type of change
- [ X]New feature (non-breaking change which adds functionality)
How Has This Been Tested?
- vsgExamples/vsglights
- various descriptor buffers in our application
Checklist:
- [X ] My code follows the style guidelines of this project
- [ X] I have performed a self-review of my own code
- [ X] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [X ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [X ] New and existing unit tests pass locally with my changes
- [X ] Any dependent changes have been merged and published in downstream modules
How close will this PR be to the existing BufferedDescriptorSet branch?
I have create a branch with these changes: siystar-dynamicdescriptors
I'll do a light review today but as this a significant change expect it'll take a day or so to wrap things up.
Arrrrrr, just typed in two paragraphs then went to look up a class and github losts all my text. Soo bloody frustrating when I'm having to type/use mouse my just my left hand.
Basic just is I'm still getting to know the changes in this PR. It's slow going because fricken broken wrist/arm. My current line I'm pondering on is whether we meed a dedicated vsg::BindDynamicDescriptorSet class, perhaps just integrating support for the pDynamicOffsets array should be done automatically be the existing vsg::BindDescriptorSet/BindDescriptorSets classes.
Thoughts?
I am now closing this PR as the functionality is now provided using the new dynamic data functionality.