vscode-html-languageserver-bin icon indicating copy to clipboard operation
vscode-html-languageserver-bin copied to clipboard

Bumpup update vscode-html-languageserver to 8637f10dd31c677acfe4c3a0e5f91c457aa7a00a

Open h-michael opened this issue 4 years ago • 7 comments

vscode-html-languageserver's tsconfig changed. It extends ../../shared.tsconfig.json that is https://github.com/microsoft/vscode/blob/master/extensions/shared.tsconfig.json now. So I've changed submodule directory and build.js. If this method is acceptable, put the same modifications in vscode-json-languageserver-bin and vscode-css-languageserver-bin.

h-michael avatar Dec 31 '19 01:12 h-michael

@DeltaEvo gentle ping

h-michael avatar Dec 31 '19 01:12 h-michael

Would be nice if the npm version gets updated after this gets merged too. It is two years old.

strawberry-choco avatar Jan 08 '20 19:01 strawberry-choco

While we are waiting for this pull request to be merged, @h-michael can you please provide me steps to compile your branch and generate a binary for use with my text editor?

Thanks

CSRaghunandan avatar Jan 24 '20 07:01 CSRaghunandan

@CSRaghunandan you can build by npm run pack.

h-michael avatar Mar 10 '20 00:03 h-michael

@aeschli Would you review this PR?

h-michael avatar Mar 10 '20 00:03 h-michael

@h-michael You need to ask a maintainer of this repo.

aeschli avatar Mar 10 '20 08:03 aeschli

I will review it, I'm just a little busy and I need to take time to test it

DeltaEvo avatar Mar 10 '20 08:03 DeltaEvo