vscode-icons icon indicating copy to clipboard operation
vscode-icons copied to clipboard

Custom Icon Folder Not Working on Latest VSCode

Open JustinGrote opened this issue 3 years ago • 18 comments

  • [x] I'm sure this issue is not a duplicate.

Platform: Windows 10 Code: Code Insiders

I've added the custom folder path at C:\Users\JGrote\AppData\Roaming\Code - Insiders\User\vsicons-custom-icons and placed file_type_bicep.svg and added relevant config to vsicons.associations.files:

        {
            "icon": "bicep",
            "extensions": [
                "bicep"
            ],
            "format": "svg",
        },

However the icon does not apply after a reload window:

image

But if I copy the file directly into the extension directory (C:\Users\JGrote\.vscode-insiders\extensions\vscode-icons-team.vscode-icons-11.1.0\icons), it works fine: image

I also tried a custom path with the extension setting with no luck. I tried adding the folder C:\users\jgrote\.vscode-insiders\vsicons-customicons and tried several combinations without success: C:/Users/JGrote/.vscode-insiders C:\\Users\\JGrote\\.vscode-insiders (double backslash in the json for escaping, reports correctly in the UI) <<Above folders with vsicons-customicons appended even though that isn't what is required per the wiki>>

Everything is on the same drive, no cross-drive boundaries.

Am I missing something here? Any logs to troubleshoot?

JustinGrote avatar Mar 04 '21 16:03 JustinGrote

Of note: I got it to work with a portable code installation: image

Will now try portable code-insiders, wondering if this is insiders specific.

EDIT: Yep definitely insiders, did same config on a insiders portable installation and it doesn't work: image image

Potentially related to one of these recent icon related commits? https://github.com/microsoft/vscode/commit/b3b60ff1162877702cc401c9a9328642c5978318 https://github.com/microsoft/vscode/commit/f3ec084d5429bc7573789b507f0b9e916e7b61ec https://github.com/microsoft/vscode/commit/684f61b4567ade085e320d9c686ae3d25c60209a

JustinGrote avatar Mar 04 '21 17:03 JustinGrote

I'm seeing a similar issue with latest. For me, I have the custom icon folder set and it attempts to access the (valid) svg icon in the correct path (which I can verify in a browser window), however opening developer mode in vscode shows the file request as (canceled):

image

If I were to hazard a guess, this is like a CORS issue, but I'm not certain since I am unfamiliar with how to further drill down on this issue.

Please let me know if this looks like the same issue and, if not, I'll migrate it to one of its own.

Version: 1.54.1
Commit: f30a9b73e8ffc278e71575118b6bf568f04587c8
Date: 2021-03-04T22:42:18.719Z (21 hrs ago)
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Darwin x64 19.6.0

flowchartsman avatar Mar 05 '21 20:03 flowchartsman

@flowchartsman totally forgot about devtools for this. I saw the same image

JustinGrote avatar Mar 05 '21 20:03 JustinGrote

Relevant settings:

  "vsicons.customIconFolderPath": "/Users/andy/.vscode/custom-icons",
  "vsicons.associations.files": [
    {
      "icon":"magefile",
      "format":"svg",
      "extensionsGlob":["go"],
      "filenamesGlob": ["magefile"],
      "filename":true
    }
  ],
~/.vscode
❯ ls -la
total 8
drwxr-xr-x   5 andy  staff   160B Mar  5 13:42 .
drwxr-xr-x+ 77 andy  staff   2.4K Mar  5 14:08 ..
-rw-r--r--   1 andy  staff   984B Sep 29 13:32 argv.json
drwxr-xr-x   3 andy  staff    96B Mar  5 14:02 custom-icons
drwxr-xr-x  58 andy  staff   1.8K Mar  5 13:56 extensions

~/.vscode
❯ ls -la custom-icons/
total 0
drwxr-xr-x  3 andy  staff    96B Mar  5 14:02 .
drwxr-xr-x  5 andy  staff   160B Mar  5 13:42 ..
drwxr-xr-x  3 andy  staff    96B Mar  5 14:26 vsicons-custom-icons

~/.vscode
❯ ls -la custom-icons/vsicons-custom-icons/
total 88
drwxr-xr-x  3 andy  staff    96B Mar  5 14:26 .
drwxr-xr-x  3 andy  staff    96B Mar  5 14:02 ..
-rw-r--r--@ 1 andy  staff    41K Mar  5 14:19 file_type_magefile.svg

~/.vscode
❯ xattr custom-icons/vsicons-custom-icons/file_type_magefile.svg
com.apple.lastuseddate#PS

So it's not quarantined or anything, either.

flowchartsman avatar Mar 05 '21 20:03 flowchartsman

FWIW, I am having the same issue in the latest VS Code (non-insiders) and no custom folder - with the same (canceled) status

Settings

"vsicons.associations.files": [
        {
            "icon": "example",
            "extensions": ["example"],
            "format": "svg"
        }
    ],
Version: 1.54.1
Commit: f30a9b73e8ffc278e71575118b6bf568f04587c8
Date: 2021-03-04T22:38:50.094Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Linux x64 5.4.0-66-generic snap

nobrayner avatar Mar 09 '21 06:03 nobrayner

same issue with the latest VScode (non-insider), the custom icons folder did not work, <C:\Users\<your_user>\AppData\Roaming\<Code Folder>\User\vsicons-custom-icons> not work. only thing works is put the icon directly into the (...\vscode-icons-team.vscode-icons-11.1.0\icons)

GreyElec avatar Mar 09 '21 08:03 GreyElec

After reinstalling VScode because it complained about my install being corrupt i ran into this same issue, non-insider version on my end so it actually seems like a problem with latest VScode in general,

my folders persisted from the previous install where it still worked

#2719 seems to be the same problem

@JustinGrote might change the title back since it's not only insider specific?

dotty-dev avatar Mar 09 '21 14:03 dotty-dev

Same problem here. VSCode version 1.54.3 vscode-icons version 11.2.0 Captura de pantalla 2021-03-23 172023

gmr458 avatar Mar 23 '21 22:03 gmr458

same problem here. VSCode 1.54.3 vscode-icons version 11.2.0

image

image

dgzornoza avatar Mar 31 '21 10:03 dgzornoza

What is the workaround with this issue? Looks like took a while to resolve this issue.

I just copied all the custom icons into C:\Users\latif\.vscode\extensions\vscode-icons-team.vscode-icons-11.1.0\icons but still didn't work, instead, whenever open my VSCode, the notification said that the integrity check did not pass on vsicons.

latipun7 avatar Apr 09 '21 16:04 latipun7

Only workaround I'm aware of is revert the extension to a version prior to the issue.

JustinGrote avatar Apr 09 '21 16:04 JustinGrote

Only workaround I'm aware of is revert the extension to a version prior to the issue.

I tried reverting up to 10.2., no success.

I reverted VS Code to v1.53, and latest VS icons 11.40 works.

Perhaps VS Code broke something, not this extension.

kreso22 avatar Apr 09 '21 19:04 kreso22

@latipun7 can you test it with the latest version of the extension 11.4.0? If you received that integrity notification makes me think that you may not be in the latest one and probably you're using portable vscode?

robertohuertasm avatar Apr 09 '21 20:04 robertohuertasm

@robertohuertasm I tried:

  • copy all custom icons file to extension icons folder: C:\Users\latif\.vscode\extensions\vscode-icons-team.vscode-icons-11.4.0\icons
  • copy custom icons folder vsicons-custom-icons to extension icons folder

Both of them didn't work, the custom icons not showing, the integrity is compromised. integrity

Then tried to move custom icons folder vsicons-custom-icons to C:\Users\latif\.vscode and edit the settings:

"vsicons.customIconFolderPath": "C:\\Users\\latif\\.vscode"

no integrity warning, but still cancelled, the custom icons not showing.

Additional info for VSCode version:

Version: 1.55.1 (user setup)
Commit: 08a217c4d27a02a5bcde898fd7981bda5b49391b
Date: 2021-04-07T15:06:02.360Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Windows_NT x64 10.0.19042

Info for extension:

vscode-icons: 11.4.0

Run on WSL and local has same behavior for me.

Thank you.

latipun7 avatar Apr 10 '21 23:04 latipun7

since nobody pointed this out yet i got i working with the vsicons.customIconFolderPath setting

as follows: add a folder "vsicons-custom-icons" in %userprofile%/.vscode/extensions/ add your custom icons there should look like this:

.vscode
 ┣ extensions
    ┣ vsicons-custom-icons
      ┗ file_type_[YOUR-CUSTOM-ICON].svg

add "vsicons.customIconFolderPath":"C:/Users/[USER]/.vscode/extensions/", to your settings.json (change the [USER] part to your user profile)

add config for association as usual

Reload Window/ Restart vscode should show up now

i chose the extensions folder since i read on the material icons issue tracker (where they also have problems with custom icons...) that they got it working putting their icons in a subfolder to the vscode extensions folder and since i was trying if that at least worked i came up with doing this here, I don't know if other custom folder paths work

Edit: @ankurp-meditab pointed out something you might have to do aswell:

run the command (ctrl + Shift + P) >icons: Apply Icons Customization. After running the command it started working

dotty-dev avatar Apr 15 '21 13:04 dotty-dev

@AlexisDot Thanks, it worked.

gmr458 avatar Apr 15 '21 14:04 gmr458

@AlexisDot The only missing thing in your workaround for me was to run the command (ctrl + Shift + P) >icons: Apply Icons Customization. After running the command it started working. Thank you very much for the workaround.

ankurp-meditab avatar Apr 25 '21 06:04 ankurp-meditab

@ankurp-meditab Added it to my post so others don't need to look for that particular bit

dotty-dev avatar Apr 25 '21 10:04 dotty-dev