Veikko Sariola

Results 96 comments of Veikko Sariola

> > Gain value of 80 is converted to float with x/128.0 so the gain is 0,625, and then if you send signal x to it with send amount 128,...

Something is still off in the latest version: ![image](https://github.com/user-attachments/assets/d9296f7b-94ff-4ff0-b73f-837aa721c9c3) Also, I managed to make the tracker crash: ``` ... C:/Users/sariola/go/pkg/mod/[email protected]/op/clip/clip.go:105 +0x31 panic({0x7ff746319b40?, 0x7ff746287100?}) C:/Program Files/Go/src/runtime/panic.go:785 +0x136 github.com/vsariola/sointu/tracker.(*Model).collectSendSources.func1(0xc003810ce0) c:/Users/sariola/git-repos/sointu/tracker/derived.go:214 +0x34e slices.AppendSeq[...]({0x0,...

In FindParamForModulationPort, the param.CanModulate is handled incorrectly, because it returns the stereo parameter (which has CanModulate false) if the index is 0. Should be: ``` func FindParamForModulationPort(unitName string, index int)...

You can see that when selecting envelope attack as the send target, it does not highlight: ![image](https://github.com/user-attachments/assets/225c9912-25a9-4c93-9829-4c5e71a36c4f) ![image](https://github.com/user-attachments/assets/20d25448-19e3-4401-8071-06ed82ed9222)

LGTM, thanks! Merged, thank you for your contribution ❤️

Uh oh, I tried looking into the higher level and it's a bit above my paygrade. I'm wondering if all these objects are getting created unnecessarily in the first place,...

I tried and failed so far. But the approach I took was using the hash/fnv (https://pkg.go.dev/hash/fnv) to compute a hash from the actual op data and use that as a...

The Hash interface has Reset() function so that same hashing function can be used several times. They are interfaces so the hash state is located in heap, but we only...

Most likely because the -call includes the DEFAULT chunk, did you try listing the chunks you need explicitly?