Vitalii Samofal comments

Results 18 comments of


                                            Vitalii Samofal

Request limit, meta, and data have different elements' count

can you create a simple test to reproduce it, and share more details about entities and data that you have, or at least the test will be enough

This package does not adhere fully to JSON:API 🥲

@Helveg looks like a good idea Do you use some tool that is required to comply with this format?

This package does not adhere fully to JSON:API 🥲

we also have swagger now, it need to be adjusted as well, once you finish I can help with it

This package does not adhere fully to JSON:API 🥲

@ppetzold I'm ok as well

This package does not adhere fully to JSON:API 🥲

@Helveg just a note, it will make sense to release those fixes one by one, having it all in one will be hard to review properly

JSON:API compliant query parameters

we also need to update docs and swagger now

seachableColumns doesn't accept camelCase, only snake_case

@jhrncar I think you can configure typeorm naming strategy, and then it will work. [typeorm-naming-strategies](https://www.npmjs.com/package/typeorm-naming-strategies)

Port mapping for ipv4 & ipv6 can cause different ports to be mapped and getMappedPort function will return wrong port

The order actually is quite random, even in one test execution, we do start redis & postgres, we have around 20 files with tests, and for each file we start...