Vince Salvino

That's a good point about the keyring adding performance overhead (shuffling it back and forth to update it each time). Rather than maintain a keyring at all, it would be...

I think the database is actually a good idea. It would only need to be written when updating the cache, so the performance hit is reasonable. However I would want...

Very nice implementation. Thank you! I left a few comments. Also, another bug fix has been merged in recently (adds a try/catch in `UpdateCacheMiddleware` so you may need to rebase...

Interesting - are you using ASGI by chance? Or is this caused by concurrent calls to `clear_expired()`?

Hi @DylannCordel - another refactor (not related to use on snippets, but related to splitting out into mixins) is going in via #71 . Could you take a look at...

This would be amazing! I have tried to use mactype on many different occasions (too many to count). It is remarkable in what it does, however it is rather buggy...

Great implementation. For the CRX navbars, we use a similar approach, except with a Site setting instead of a ForeignKey. The reason we didn't do multi-site in the pro boilerplate...

Nice work, thanks! We can remove that fallback code as it is not necessary and should simplify it a bit. Tests aren't necessary here, as long as you manually tested...

Looking good, left a few more comments. I think it will be ready to merge after that.

Thanks... this looks good. Just one step is needed before I can merge this. Need to compile the css from the sass, then commit the result: https://docs.coderedcorp.com/wagtail-crx/contributing/index.html#css-development