Vincent Roulet

It's been fixed in #972. Should be merged tomorrow.

Thanks! Can you add it to the list of common tests of the contrib folder?

Yes. People may want to combine this scale function with e.g. a clipping, so the documentation helps. This is just a nitpick to finalize the contrib.

Perfect, I'll take it from here (I need to make some internal changes to add this optimizer to our builds). Thanks again

It should have been closed automatically but yes, let me close it

Thanks again @GrantMcConachie ! Quick question: do you think it could be handled by a `jnp.where`? Imagine for example that you want to normalize a vector and handle the case...

Hello @GrantMcConachie, Thanks for trying! We may have had a misunderstanding. The issue you get is when all labels the same. This should not have anything to do with the...

Hello @amosyou (sorry got too many mails didn't catch this notification). It's better not to have a docstring than having a confusing one. So yes, you can remove :members: to...

That's great, it will really make the doc more readable! For SAM's State let me handle that internally.

Could you also merge with main to see latest changes? (for example I'm not sure why States such as ClipState are displayed as alias of tuple instead of alias of...