vrc-oscquery-lib icon indicating copy to clipboard operation
vrc-oscquery-lib copied to clipboard

Allow custom websocket implementations

Open joreg opened this issue 2 years ago • 2 comments

By adding WS_PORT and WS_IP to the HostInfo as defined in the OSCQuery required attributes, we can implement the bi-directional websocket support outside of this library.

joreg avatar Oct 10 '23 15:10 joreg

@joreg - thanks for submitting this PR. The OSCQuery spec is a little vague about how to specify that a server support Websockets or not. My best understanding is that a server that does not support them should not provide them as fields when returning a HOST_INFO request, but this implementation provides them by default now. What do you think about only including them if they are passed to the fluent constructor?

momo-the-monster avatar Aug 26 '24 20:08 momo-the-monster

sounds good to me!

joreg avatar Aug 26 '24 20:08 joreg