UdonSharp icon indicating copy to clipboard operation
UdonSharp copied to clipboard

0Harmony.dll should not be included in the VPM package.

Open kay-xr opened this issue 2 years ago • 2 comments

Describe the bug in detail: Including 0Harmony.dll in the main package will automatically break other harmony-dependent packages, when Harmony is installed manually or from a specific Harmony VPM package. This should be changed to install as a dependent package from a registry, while checking for Harmony on import.

Provide steps/code to reproduce the bug: Import UdonSharp using VRCC in any project already using Harmony, such as RATS

Expected behavior: UdonSharp should check for Harmony on import.

Additional Information: Console errors with conflicting dependencies will clear when requested, therefore this issue is easy to miss, and can be complicated to track down.

kay-xr avatar May 09 '23 01:05 kay-xr

I agree, this creates complications for other tooling that depends on Harmony.

I think a solid solution would be providing it as an official package through VCC, so other packages can depend on it: https://github.com/vrchat-community/creator-companion/issues/75

rrazgriz avatar May 11 '23 14:05 rrazgriz

com.vrchat.base 3.4.0 now bundles Harmony, which smooths handling of the Harmony dependency: https://github.com/vrchat-community/creator-companion/issues/75#issuecomment-1751513947

rrazgriz avatar Oct 07 '23 00:10 rrazgriz