node-soap icon indicating copy to clipboard operation
node-soap copied to clipboard

Published 20 hours ago • verified publisher icon vpulim

Allow options in objectToDocumentXML when calling a method

Open ndeniche opened this issue 4 years ago • 5 comments

Allows overriding the InputMessage "Request" element for custom elements based on args param

  • Options is optional field for objectToDocumentXML function
  • Replicates _xml parameter functionality (sending a custom XML structure as a literal) with JSON arguments.

ndeniche avatar Nov 08 '19 04:11 ndeniche

Coverage Status

Coverage decreased (-0.5%) to 94.529% when pulling 130c2045a2ff51da3b385c06a9923e3df83d3668 on ndeniche:ndeniche_override-base-element into af93a6f45720431371ab3f23866d3ad3f2efae1b on vpulim:master.

coveralls avatar Nov 08 '19 04:11 coveralls

@ndeniche please add more tests to cover all scenarios.

jsdevel avatar Nov 08 '19 17:11 jsdevel

i'm closing this in 4 days if there's no more action

jsdevel avatar Nov 14 '19 17:11 jsdevel

All of my new code is covered. Should I improve coverage by adding tests to other features?

ndeniche avatar Nov 17 '19 02:11 ndeniche

@ndeniche if coverage has decreased, then not all the added code has been covered.

jsdevel avatar Nov 18 '19 18:11 jsdevel