toqito icon indicating copy to clipboard operation
toqito copied to clipboard

Error in reference for states.chessboard

Open Shivansh20128 opened this issue 1 year ago • 4 comments

Before reporting this bug:

  • [x] Verify there is not an existing issue for it already
  • [x] You are using the latest version of toqito with a python version >=3.10

Describe the bug

A clear and concise description of what the bug is. The references given for the states.chessboard are wrong here. The references given actually are meant for w_states, and are not related to chessboard states.

To Reproduce

Describe the steps to reproduce the bug. Use markdown syntax with inline code and/or code blocks to make your code readable. See the docs here.

Expected behavior

A clear and concise description of what you expected to happen. Use markdown syntax with inline code and/or code blocks to make your code readable. The reference should be related to how chessboard states are defined.

Screenshots

If applicable, add screenshots to help explain your problem.

System Information where toqito is installed

Shivansh20128 avatar Oct 07 '24 18:10 Shivansh20128

Hi @Shivansh20128 ,

Thanks for opening this. If you could describe the error you noticed in question, that would be excellent. Thank you again for your contributions to the toqito project!

vprusso avatar Oct 07 '24 20:10 vprusso

I have described the error above. If you look at the documentation for states.chessboard here, and go below to the references, you will see that the given reference is "W. Dür, G. Vidal, and J. I. Cirac. Three qubits can be entangled in two inequivalent ways. Physical Review A, Nov 2000. URL: http://dx.doi.org/10.1103/PhysRevA.62.062314, doi:10.1103/physreva.62.062314.". This reference should not be here as it does not relate to Chessboard states. (The reference is actually for w_states). The references should be modified for this submodule. Thank You

Shivansh20128 avatar Oct 08 '24 05:10 Shivansh20128

Ah, you are indeed correct, @Shivansh20128 (excellent catch).

Indeed, the correct reference should be: https://journals.aps.org/pra/abstract/10.1103/PhysRevA.61.030301

Again, great catch and attention to detail!

vprusso avatar Oct 08 '24 10:10 vprusso

Okay, thank you. I will give this paper a read because it seems very different than what I thought the chessboard state was. It does not appear to be related to Quantum Chess😳. I am learning a lot of things from this project. You can close this issue once the changes are made. Thank you

Shivansh20128 avatar Oct 08 '24 12:10 Shivansh20128

Fixed!

Shivansh20128 avatar Nov 16 '24 10:11 Shivansh20128