toqito icon indicating copy to clipboard operation
toqito copied to clipboard

Removing redundant note for doctest.

Open vprusso opened this issue 1 year ago • 4 comments

Closes #650

vprusso avatar Jul 07 '24 13:07 vprusso

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.7%. Comparing base (372c205) to head (c3111f3). Report is 305 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #651   +/-   ##
======================================
  Coverage    97.7%   97.7%           
======================================
  Files         166     166           
  Lines        3250    3250           
  Branches      795     795           
======================================
  Hits         3176    3176           
  Misses         48      48           
  Partials       26      26           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 07 '24 13:07 codecov[bot]

It appears all over the place, and I find this a bit distracting (especially when noted numerous times in the same tutorial, etc.)

I am fine with removing this if it is repeated across one page.

We should mention it once for the other pages. The things required by DOCTEST don't make sense for someone who is not familiar with why we are using something in the print output. What if they copy-paste an example into a local jupyter notebook? I had added it for this reason.

purva-thakre avatar Jul 07 '24 20:07 purva-thakre

It appears all over the place, and I find this a bit distracting (especially when noted numerous times in the same tutorial, etc.)

I am fine with removing this if it is repeated across one page.

We should mention it once for the other pages. The things required by DOCTEST don't make sense for someone who is not familiar with why we are using something in the print output. What if they copy-paste an example into a local jupyter notebook? I had added it for this reason.

That makes sense--I think having it at least in one place definitely makes sense. Maybe in the contribution guide?

vprusso avatar Jul 08 '24 12:07 vprusso

I think having it at least in one place definitely makes sense. Maybe in the contribution guide?

What if we create a section called Examples in the Getting Started section? We could introduce all the tutorials, point a user to the examples in the API as well as have a note for the things we use for DOCTEST.

Adding it to the contribution guide wouldn't be helpful for someone who is not interested in contributing to the project. Thoughts?

purva-thakre avatar Jul 08 '24 13:07 purva-thakre