toqito icon indicating copy to clipboard operation
toqito copied to clipboard

Refactor: Consolidated interface for quantum state distinguishability

Open vprusso opened this issue 8 months ago • 4 comments

Currently, the state distinguishability scenario can be considered when optimizing over global (i.e. positive) measurement (state_distinguishability.py) as well as PPT (ppt_distinguishability.py).

This task would consolidate the above into the state_distinguishability.py file, but allow the user to supply an additional optional argument that pertains to the class of measurements to optimize over.

The interface should support "positive", "PPT", and "separable" measurements along with the "figure-of-merit" to distinguish by (i.e. 'min-error", "unambiguous", etc.).

vprusso avatar Apr 11 '25 02:04 vprusso

Hi, could you please assign this task to me? Thank you.

jajapuramshivasai avatar Apr 11 '25 17:04 jajapuramshivasai

Hi @jajapuramshivasai

I appreciate your enthusiasm. You have two open PRs on the board, perhaps we should resolve and address those before taking on new issues. Thoughts?

vprusso avatar Apr 11 '25 17:04 vprusso

Hi @jajapuramshivasai

I appreciate your enthusiasm. You have two open PRs on the board, perhaps we should resolve and address those before taking on new issues. Thoughts?

I’m still waiting for reviews on those tasks, so I thought I could use this time to work on this in the meantime.

jajapuramshivasai avatar Apr 11 '25 17:04 jajapuramshivasai

I’m still waiting for reviews on those tasks, so I thought I could use this time to work on this in the meantime.

I provided additional comments on https://github.com/vprusso/toqito/pull/1086 and it looks like the other one https://github.com/vprusso/toqito/pull/1175 appears to be failing the pipeline.

vprusso avatar Apr 11 '25 17:04 vprusso