ficus icon indicating copy to clipboard operation
ficus copied to clipboard

Published 20 hours ago • verified publisher icon vpisarev

Bug fixed of s1d1 in NN Conv

Open zihaomu opened this issue 2 years ago • 2 comments

Fix the critical error in s1d1. It can pass all the regression test in opencv_extra. And I will update the s1d1 of FP16 tomorrow.

zihaomu avatar Jun 01 '22 14:06 zihaomu

@zihaomu, big thanks for the pull request! I noticed it only this weekend. It will take some time for me to learn the differences between your and my implementation. In my case I do not observe wrong behaviour that you pointed out to, but I will look at it more carefully

vpisarev avatar Jun 27 '22 08:06 vpisarev

@zihaomu, big thanks for the pull request! I noticed it only this weekend. It will take some time for me to learn the differences between your and my implementation. In my case I do not observe wrong behaviour that you pointed out to, but I will look at it more carefully

Hi @vpisarev. Actually, the Error occurs when conv+padding. I also didn't find the specific location, so I re-wrote this part.

zihaomu avatar Jun 27 '22 11:06 zihaomu