vpinball icon indicating copy to clipboard operation
vpinball copied to clipboard

Keep the build folder for cmake output?

Open francisdb opened this issue 1 year ago • 1 comments

Is your feature request related to a problem? Please describe.

Somewhere during 10.8.1 refactorings a build folder was introduced in repository root which contains windows build related files. However that folder was also already used in the build instructions for standalone as the build output folder.

Is it standard practice to output to the build folder when using cmake? @jsm174

The fact that output goes in this folder and that it is also in git is quite annoying. A git status will show you this:

➜  vpinball git:(build/asahi-linux) ✗ git status
On branch build/asahi-linux
Your branch is up to date with 'francisdb/build/asahi-linux'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        build/CMakeCache.txt
        build/CMakeFiles/
        build/Makefile
        build/VPinballX_BGFX
        build/VPinballX_GL
        build/assets/
        build/cmake_install.cmake
        build/docs/
        build/flexdmd/
        build/libSDL2-2.0.so
        ...

Describe the solution you'd like

Can we rename the repository build folder to something else?

Describe alternatives you've considered

  • Adding git excludes/includes for the build folder, might be annoying to manage.
  • Switching to a different output folder in the standalone build instructions.

francisdb avatar Jun 21 '24 09:06 francisdb

fwiw, out of the box, the official "CMake Tools" and "C/C++ extension pack" extensions (from microsoft) for visual studio code write to build

jsm174 avatar Jun 21 '24 11:06 jsm174

fixed in #1838

francisdb avatar Jul 12 '24 08:07 francisdb