pinmame
pinmame copied to clipboard
vpinball
Hickup on AFM when destroying saucer in VPinmame after v.888
I have trouble with all the versions of VPinmame after "VPinMAME-sc-3.6-835-60613e8-win-x64.zip" with Attack From Mars G5K and afm_113 rom. Using latest VPX 10.8 GL. Everytime I destroy a ship, right when the explosion happens there is a small hickup in the DMD, both visual and sound. It also happens if I use ColorDMD.
See video: https://github.com/vpinball/pinmame/assets/31146448/c0e87685-4e73-4fa4-a961-0c76deeb4687
@Regulations do you use an altsound package or rom/emulated sound?
I'm using rom sound.
Alt. Sound Mode=0
Here to confirm this bug. Tested with GL and regular (DX?) VPX 10.8.0 RC3 and RC2. Problem disappears with vPinMame 3.6-822. Just a slight pause/hickup during the final explosion of the UFO and the UFO solenoid does't fire the final time. Tested on two different tables and it happens on both. I'm on afm_113b rom, no altsound.
https://github.com/vpinball/pinmame/assets/5919849/d729d807-2209-40c6-93ce-7fb8f4f6d654
I noticed it yesterday while testing my colorization and you can easily see AND hear the glitch here: https://youtu.be/TSkgCbfZDZk?t=72
noticed this on medieval madness, too. upon destroying a castle. (109c)
also with demolition man when the game resets after match feature. (h6b)
Just here to confirm this issue.. Just a slight pause on latest vpinmame
noticed this on medieval madness, too. upon destroying a castle. (109c)
also with demolition man when the game resets after match feature. (h6b)
Good to see we at least see the same. I asked in VPW Discord about some of the oddities but no-one tried to verify my findings. Haven't tried demo-man, but, I can't get the draw bridge to drop for MM.
The draw bridge is a script issue and has been posted
On Fri, Apr 26, 2024, 9:06 AM Thalamus @.***> wrote:
noticed this on medieval madness, too. upon destroying a castle. (109c)
also with demolition man when the game resets after match feature. (h6b)
Good to see we at least see the same. I asked in VPW Discord about some of the oddities but no-one tried to verify my findings. Haven't tried demo-man, but, I can't get the draw bridge to drop for MM.
— Reply to this email directly, view it on GitHub https://github.com/vpinball/pinmame/issues/268#issuecomment-2079361173, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3OIIA5KVNO36XLDVXJULBLY7JGNLAVCNFSM6AAAAABGVMXCRSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZZGM3DCMJXGM . You are receiving this because you commented.Message ID: @.***>
Great video of it lagging out. https://www.facebook.com/share/v/D42Mib4mVKmJckoo/?mibextid=oFDknk
Sorry this is upside down... but Bride of Pinbot is another clear example, especially in the post-game music, as seen here.
https://github.com/vpinball/pinmame/assets/128234486/4520e4ce-803f-4d95-ae10-7cf8727981d0
@lminimart I think this bug is about the animation stutter as shown in the video of the first post on AFM. There is also a bug regarding sounds stutters in WPC here: https://github.com/vpinball/pinmame/issues/266#issuecomment-2081416325
Regarding the initial bug, I made some testing and I'm not able to reproduce in PinMame, while I always have it when using VPinMame. Note that the same goes for the sound WPC stutter bug.
Saw that other report, and the Scared Stiff comments there are indeed what I'm referring to. I suppose I conflated them, tho they seem related. Just glad it's being looked into!
Some news on this: I took the time to look more in depth on the bug. It is clearly linked to the new PWM implementation as it is trigger since these tables use the legacy MODSOL which is now implemented using the new PWM path.
The issue seems to be a performance issue: on some situations the amount of update seems to rise fairly high (for AFM, all lights and flashers blinking when saucer is destroyed for example). The profiler shows as the biggest offender the eye flicker/fusion filter which is called a lot. The YM FM emulation is also quite heavy. I guess the sound stutters may have the same cause.
Curious: does this mean more powerful systems won't see the issue? Based on reports from others i know with pretty powerful systems, it sure seems to occur on those types of pcs, as well.
@lminimart I made an experimental build with some improvments to this. If you can give it a try and see if it improves (solves ?) the bug for you, that would be nice. The build is here: https://github.com/vpinball/pinmame/actions/runs/8885882588
very happy to give it a go! i'll report back.
EDIT: i tried it out on a secondary test system i have (very low powered) and it was mostly fine, but ... there were still occasional stutters in the after game music (this was VPW's bride of pinbot). an improvement but not 100% improvement. still better than my most powerful system with the currently released beta.
Did it performs better with an old PinMame (the difference is now very slight) ?
Yes, the vpinmame I had installed before the latest beta never exhibited any of the audio stutter I'm hearing now on any of my systems. The two games I played of Bride of Pinbot with your test vpinmame were nearly without stutter, really only audible stutter in the post-game music, but audible every time in that part of the audio. I hope I'm answering the question correctly. EDIT: i can try to get video of that post game sequence at some point today or tomorrow.
I tried the latest @toxieainc port speedup part of https://github.com/vpinball/pinmame/pull/270 by vbousquet: VPinMAME-sc-3.6.0-948-5ca69dc-win-x64 and now the problems are vanished! No more hickup upon destroying the saucer! =) Thank you!
@lminimart I made an experimental build with some improvments to this. If you can give it a try and see if it improves (solves ?) the bug for you, that would be nice. The build is here: https://github.com/vpinball/pinmame/actions/runs/8885882588
Confirmed working fine with this version here.
SECOND EDIT: even sorrier than before lol... I am getting confused on my versions! So...
VPinMAME-3.6.0-947-44c1fed-win-x64: this was the version I tested yesterday and it is an improvement. Yesterday, I heard slight stutter in the post-game music on BoP, but today, I don't think I heard any. Going to keep playing now and then when I have time and keep listening. EDIT: definitely still hearing slight stutter in the post-game music with this version, but it is an improvement over the publicly available beta.
VPinMAME-sc-3.6.0-948-5ca69dc-win-x64: this is the latest toxie build (I believe) and this version seems to have the same audio glitching as the current publicly available beta. So if VPinMAME-3.6.0-947-44c1fed-win-x64 has changes that aren't in VPinMAME-sc-3.6.0-948-5ca69dc-win-x64, then that's probably why.
Will keep testing... thanks @vbousquet !
Much better!
On Mon, Apr 29, 2024, 5:51 PM Vincent Bousquet @.***> wrote:
@lminimart https://github.com/lminimart I made an experimental build with some improvments to this. If you can give it a try and see if it improves (solves ?) the bug for you, that would be nice. The build is here: https://github.com/vpinball/pinmame/actions/runs/8885882588
— Reply to this email directly, view it on GitHub https://github.com/vpinball/pinmame/issues/268#issuecomment-2083745343, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3OIIA7F6BGZDPPBSH7P3N3Y726GLAVCNFSM6AAAAABGVMXCRSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBTG42DKMZUGM . You are receiving this because you commented.Message ID: @.***>
Current VPinMAME 64bit SC rev 948. Didn't notice the stutter on AFM this go around. Much better!
Closing then. Otherwise please complain again with what is still wrong with certain table(s). Thanks all!
I just commited some more tiny tweaks, maybe it improves a bit more even by that.