pinmame
pinmame copied to clipboard
Add new COM Version method including build number as double
Similar to the issue on VPX: https://github.com/vpinball/vpinball/issues/1558
Is your feature request related to a problem? Please describe. To help the flipper table creators, not having to tell in all forums which minimum version to use for VPX, VPM and B2S
Describe the solution you'd like Currently the Version method returns a string as "03060000" for VPM 3.6, it would be an improvement if the build number would be added as decimal value like "03060000.0879" (allowing 4 decimal characters), meaning one would have to change the method to return a bigger string instead.
Describe alternatives you've considered I have been thinking of using a separate Version method. But rather I would keep the same. I also considered changing the datatype to double as in VPX, but then a lot of scripts and tables would have to be changed.
Additional context I have tested the current usage of controller.FullVersion in the local vbs files, and the same if statements still work perfect.
Some examples from "core.vbs":
- If Controller.Version >= "01200000" Then
- If Controller.Version >= 03060000 Then one note, the correct usage would be to use "03060000" comparing two strings!
Using this it will be possible to test using the build number as decimal:
- Controller.Version >= 03060000.0879 is True (where Controller.Version is a string with value "03060000.0880")
The same also works in older versions
- Controller.Version >= "03060000.0879" is False (where Controller.Version is an string with value "03060000")