prometheus-slurm-exporter icon indicating copy to clipboard operation
prometheus-slurm-exporter copied to clipboard

Published 20 hours ago • verified publisher icon vpenso

Support for OUT_OF_MEMORY job state

Open nktl opened this issue 3 years ago • 3 comments

A quick patch to support OUT_OF_MEMORY job state - visibility of which is especially useful when task/cgroup plugin is used with ConstrainRAMSpace=YES option (in such case cgroup will oomkill the job if it exceeds requested memory)

nktl avatar Dec 23 '21 08:12 nktl

Can we prioritize this for merging please?

uberspot avatar Apr 27 '22 16:04 uberspot

Can we prioritize this for merging please?

My main issue with this PR is that most of the changes are due to poor formatting:

  1. Change in NewQueueCollector() is basically only one line but the commit will re-write the entire function block.
  2. Same goes for the QueueCollector struct: only one line needs to be changed not the entire structure.

mtds avatar May 20 '22 06:05 mtds

Hey, fixed the indentation / formatting as requested.

nktl avatar May 31 '22 07:05 nktl