vpx-js
vpx-js copied to clipboard
update build infos when change is detected
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.80%. Comparing base (
131a4c5) to head (9326ef9). Report is 182 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #185 +/- ##
==========================================
+ Coverage 90.79% 90.80% +0.01%
==========================================
Files 275 275
Lines 14359 14359
Branches 1678 1678
==========================================
+ Hits 13036 13037 +1
Misses 821 821
+ Partials 502 501 -1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
the only way to keep the build information up to date (for example when you switch branches) is a hook in the tsc binary (run X after compilation step).
this is not supported by tsc out of th box thus I installed tsc-watch as dev dependency.
Yes I got that, the question is whether this information is crucial during development. For example, being aware that a 2-week old version of vpx-js is used is important because it tells you that you're probably using an outdated dependency in vpweb.
This PR adapts changes you actively provoke locally, so I'm wondering if there is a use case where this actually saves you time or if it's more like a "I just want to have it right" thing.
I guess my question is: Do you think being reminded of the correct branch when switching branches during build:watch will save you more time than not having to maintain the additional dependencies?
Do you think being reminded of the correct branch when switching
i think yes - just because of the fact that i forget the npm link step a couple of times. but it might be just me being stupid..
should i fix the conflict or decline?
I'm still leaning towards closing. But let's wait a few days, and if you come across a case where this would have saved you time during development, I'll let you rebase and merge.